Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Konclude instead of Hermit for CI #219

Open
mrnolte opened this issue May 13, 2022 · 8 comments
Open

Use Konclude instead of Hermit for CI #219

mrnolte opened this issue May 13, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@mrnolte
Copy link
Collaborator

mrnolte commented May 13, 2022

Because Konclude is MUCH faster (up to 50.000 times)

@mrnolte mrnolte added the enhancement New feature or request label May 13, 2022
@sasjonge
Copy link
Collaborator

@mrnolte Can you provide a script like this for Konclude:

https://github.com/ease-crc/soma/blob/master/scripts/hermit_test.py

Then I could add it to the CI

@sasjonge
Copy link
Collaborator

We could also solve this Issue in the same PR:

#206

@mrnolte
Copy link
Collaborator Author

mrnolte commented May 19, 2022

I unfortunately have no idea how to update the CI, although i can certainly write a java script that asks conclude for the subclasses etc. However, Konclude would have to be started and stopped externally (starting works via java, stopping not)

@sasjonge
Copy link
Collaborator

CI is generally very simple you just tell it which commands to run, see here:

run: sudo cp ./owl/DUL.owl $GITHUB_WORKSPACE/build/DUL.owl

Is there not alternative to having Konclude started and stopped explicitly? So you can't like with hermit, just call it on the commandline?

Also I would prefer using Python over javascript, else we would have to install javascript in the ci too. The hermit script basically executes commandline commands, couldn't we do the same for Konclude?

@mrnolte
Copy link
Collaborator Author

mrnolte commented May 19, 2022

Not javascript, a script written in Java. But i guess we can try to use konclude this way to

@mrnolte
Copy link
Collaborator Author

mrnolte commented May 19, 2022

However, i only used Konclude via OwlLink - maybe @mpomarlan knows best using Konclude via Command Line?

@mpomarlan
Copy link
Collaborator

I'll have a look at it. Indeed, Konclude works via command line too, and I think the first version of the CI actually used it :)

@mpomarlan
Copy link
Collaborator

I'm writing a version of this script for Konclude but I encounter a problem: Konclude doesn't seem to return an object property hierarchy.

The "classification" command (available for the command line) returns the class hierarchy only. The command line also allows sending an owllink request, but the GetSubObjectProperties and GetSubObjectPropertyHierarchy return "node not supported" messages.

On the other hand, maybe this isn't too big a limitation. Whenever we've had a problem with a property being empty, so far it was because its domain or its range was empty, and we would still catch that. I'll write the script and make a pull request later. We can always add stuff if we figure out something/Konclude adds new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants