From fca848559c8771cb3915fafd92b6fbd58f5e185a Mon Sep 17 00:00:00 2001
From: Mike <mikejholly@gmail.com>
Date: Fri, 24 May 2024 14:11:16 -0700
Subject: [PATCH] Commit all refs aside from "run once" group

---
 solver/simple.go | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/solver/simple.go b/solver/simple.go
index 752ba3d98..d7050b61f 100644
--- a/solver/simple.go
+++ b/solver/simple.go
@@ -134,11 +134,6 @@ func (s *simpleSolver) build(ctx context.Context, job *Job, e Edge) (CachedResul
 		})
 	}
 
-	err := s.commitRefFunc(ctx, ret)
-	if err != nil {
-		return nil, err
-	}
-
 	return NewCachedResult(ret, expKeys), nil
 }
 
@@ -210,6 +205,15 @@ func (s *simpleSolver) buildOne(ctx context.Context, runCacheMan *cacheKeyManage
 		}
 	}
 
+	// Some operations need to be left in a mutable state. All others need to be
+	// committed in order to be cached and loaded correctly.
+	if !isRunOnce {
+		err = s.commitRefFunc(ctx, res)
+		if err != nil {
+			return nil, "", err
+		}
+	}
+
 	err = s.resultSource.Link(ctx, cacheKey, res.ID())
 	if err != nil {
 		return nil, "", err
@@ -445,14 +449,8 @@ func (m *cacheKeyManager) cacheKeyRecurse(ctx context.Context, d digest.Digest,
 		io.WriteString(h, c.salt)
 	}
 
-	for _, in := range c.inputs {
-		err := m.cacheKeyRecurse(ctx, in, h)
-		if err != nil {
-			return err
-		}
-	}
-
 	io.WriteString(h, c.digest.String())
+
 	for _, dep := range c.deps {
 		if dep.selector != "" {
 			io.WriteString(h, dep.selector.String())
@@ -462,6 +460,13 @@ func (m *cacheKeyManager) cacheKeyRecurse(ctx context.Context, d digest.Digest,
 		}
 	}
 
+	for _, in := range c.inputs {
+		err := m.cacheKeyRecurse(ctx, in, h)
+		if err != nil {
+			return err
+		}
+	}
+
 	return nil
 }