Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TensorStore to performance benchmarks #570

Open
alxmrs opened this issue Jan 13, 2025 · 2 comments
Open

Add TensorStore to performance benchmarks #570

alxmrs opened this issue Jan 13, 2025 · 2 comments

Comments

@alxmrs
Copy link

alxmrs commented Jan 13, 2025

I'm really excited to see the great read throughput improvements from Icechunk on Zarr v3! I'm curious how read throughput performance compares to TensorStore.

Having a place for consistent comparison would be really fruitful for Xarray data loaders, like xbatcher (xarray-contrib/xbatcher#42) (or eventually neuralgcm/neuralgcm#97.)

xref: google/tensorstore#49

@alxmrs
Copy link
Author

alxmrs commented Jan 13, 2025

Adding useful pointer to a comment (that might otherwise get lost):
https://github.com/neuralgcm/neuralgcm/blob/ddf63000d635e21be7dc38f3242d9d829af40fd9/neuralgcm/reference_code/reader.py#L395

@rabernat
Copy link
Contributor

Thanks for this Alex! While we're excited about the initial benchmarking results, performance is not our current focus. We're still mainly focused on correctness, feature implementation, and stabilization of the file formats. So we won't be prioritizing this comparison in the near term.

We welcome you and anyone else to do comparisons if you wish, bearing in mind that basically zero effort has gone into performance optimization in Icechunk, and thus there remain many low-hanging fruits in terms of optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants