Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tracing on bad requests, using starlette+connexion+flask #98

Open
leclercmartin opened this issue Feb 28, 2024 · 0 comments
Open

No tracing on bad requests, using starlette+connexion+flask #98

leclercmartin opened this issue Feb 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@leclercmartin
Copy link

leclercmartin commented Feb 28, 2024

Describe the bug
No trace is sent to Dynatrace on detected bad requests (HTTP status 400), when using the stack starlette:0.32.0.post1 + connexion:3.0.5 + flask:3.0.0.

When doing some other tests, I see tracing of requests for there use cases:

  • 200: successful request handled
  • 404: no resource found
  • 500: internal error

Here is my observation. The new version of connexion (v3 - ASGI) handles the request before delegating to flask. In the different scenarios listed above, successful processing, no resource found or internal error, they all pass through flask code. The case of bd request, connexion detects the base request and calls its error handling mechanism (which can be overriden)

To Reproduce
Steps to reproduce the behavior:

  1. Create a dummy application using the connexion guideline, using FlaskApp, with simple openapi definition, adding a dependency on autodynatrace and appropriate configuration
  2. Send an valid vs invalid request
  3. Dynatrace will contain only the successful traces
  4. No error found in log...

Expected behavior
I would expect that the bad requests be reported in Dynatrace.

Thanks in advance for your help.

@leclercmartin leclercmartin added the bug Something isn't working label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant