Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SINDyPI was added to init. It is not recognizable otherwise #577

Closed
wants to merge 1 commit into from

Conversation

heidariarash
Copy link

SINDyPI is not recognizable by following the documenations. I added it to both the init file of the optimizer.py and init_.py

@Jacob-Stevens-Haas
Copy link
Member

Can you describe what issue this is supposed to fix? SINDy-PI is already imported in these files if you have the extras for cvxpy available

@heidariarash
Copy link
Author

Thanks for the comment.

Yes, I didn't realize the import statements in the try-except statement, maybe I should have raised this as an issue, as my colleuge also encountered this problem.

If cvxpy is not installed, SINDyPI won't be imported, and an error showing the SINDyPI module is not available (or not found) will be shown, without any more information. I added SINDyPI import statements manually, and I realized that cvxpy is not installed. Maybe it's better to just add cvxpy as a dependency, or to give a more informative error/warning, by importing SINDy in the beginning (Such as cvxpy not found, some modules such as SINDyPI might not be available).

It would be also beneficial to add this in the documentation for SINDyPI notebook: "Make sure to install cvxpy before running this example". I am not sure if this is mentioned anywhere in the documentation, because I was not able to find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants