Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust Client.close(), no client/solver/future reuse after close #217

Open
randomir opened this issue Jul 19, 2018 · 0 comments · May be fixed by #680
Open

Robust Client.close(), no client/solver/future reuse after close #217

randomir opened this issue Jul 19, 2018 · 0 comments · May be fixed by #680

Comments

@randomir
Copy link
Member

randomir commented Jul 19, 2018

After Client.close():

  • all workers have to be killed, immediately if user doesn't want to wait for results (which they are now too, but in a blocking manner)
  • all solvers have to be invalidated, so no future submissions are possible (channel is closed),
  • all futures have to be resolved (with timeout/shutdown error if Client.close(wait=False))

EDIT: for consistency with ThreadPoolExecutor.shutdown(), we're not implementing "immediate close" option. We could support wait=False behavior, but for little benefit -- all jobs/workers would need to finish either way, the difference would only be in close() returning immediately or not. The program wouldn't finish (exit would block) until all workers finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant