Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #129

Open
nikonikoniko opened this issue Jul 6, 2022 · 1 comment · May be fixed by #130
Open

fix tests #129

nikonikoniko opened this issue Jul 6, 2022 · 1 comment · May be fixed by #130
Assignees

Comments

@nikonikoniko
Copy link
Contributor

Our refactor has broken the tests. I assume the imports are silly.

We can also set up the tests to:
-- test the services and their construction. this would involve mocking them.

@tlmn tlmn self-assigned this Jul 6, 2022
@tlmn
Copy link
Member

tlmn commented Jul 6, 2022

Yes, I think it broke when we did the type refactor and TS didn't complain since it's not checking those testing files. Will fix it.

tlmn added a commit that referenced this issue Jul 6, 2022
@tlmn tlmn linked a pull request Jul 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants