Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database action relation ship #7303

Open
flvndvd opened this issue Sep 11, 2024 · 8 comments
Open

Fix database action relation ship #7303

flvndvd opened this issue Sep 11, 2024 · 8 comments
Assignees

Comments

@flvndvd
Copy link
Contributor

flvndvd commented Sep 11, 2024

We should set the right relation ships in our data base to prevent deleting data source views and vaults that would still be used by assistants.

The most likely forward path here is to set ON DELETE RESTRICT.

First occurence to fix is reverting: #6676.

@flvndvd
Copy link
Contributor Author

flvndvd commented Sep 24, 2024

Any progress on this @fontanierh?

@spolu
Copy link
Contributor

spolu commented Sep 24, 2024

What model are we talking about? AgentQueryTableConfigurationTable or something else?

@fontanierh
Copy link
Contributor

TBH this slipped a bit, I need to understand if this is still relevant (a bunch of related code has moved quite a bit these past weeks)

@flvndvd
Copy link
Contributor Author

flvndvd commented Sep 24, 2024

The main one to fix was AgentDataSourceConfiguration but we wanted to run a proper check on all those recent updates to ensure they are not cascade.

@spolu
Copy link
Contributor

spolu commented Sep 24, 2024

The one that matters is **ConfigurationTable in the context of data sources and this one is aligned with the retrieval approach: restrict with explicit check and deletes AFAICT.

@spolu
Copy link
Contributor

spolu commented Sep 24, 2024

But maybe this is not a data source only convo?

@fontanierh
Copy link
Contributor

@flvndvd I think this is OK to close no ?

@flvndvd
Copy link
Contributor Author

flvndvd commented Oct 7, 2024

Assigning to self, will do a final pass.

@flvndvd flvndvd assigned flvndvd and unassigned fontanierh Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants