You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Describe the bug
Some places use type() instead of isinstance() when checking types (e.g. here). Using isinstance() is preferred because it's faster and also considers inheritance (and you’d probably want to still consider subclasses of dict as true in that example above - e.g. if we wanted to use an OrderedDict).
To Reproduce
n/a
Expected behavior
Check types with isinstance() instead.
System (please complete the following information):
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered:
Describe the bug
Some places use
type()
instead ofisinstance()
when checking types (e.g. here). Usingisinstance()
is preferred because it's faster and also considers inheritance (and you’d probably want to still consider subclasses ofdict
as true in that example above - e.g. if we wanted to use anOrderedDict
).To Reproduce
n/a
Expected behavior
Check types with
isinstance()
instead.System (please complete the following information):
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered: