Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing jemalloc dependency #63

Open
akoshchiy opened this issue Jul 23, 2024 · 4 comments
Open

Missing jemalloc dependency #63

akoshchiy opened this issue Jul 23, 2024 · 4 comments

Comments

@akoshchiy
Copy link
Contributor

Seems that duckdb sources is not bundled with jemalloc. duckdb/duckdb#13075
It could be the reason of some memory issues, e.g. duckdb/duckdb#9712

@brianwyka
Copy link
Contributor

@lnkuiper , do you think this could be the issue?

@lnkuiper
Copy link
Contributor

@akoshchiy, indeed, the JDBC client has not been bundled with jemalloc since we moved it out of the main repository to this repository. I don't see why it can't be bundled with jemalloc, so we should look into this.

@brianwyka, I'm not sure. I have been able to reproduce a similar memory retention issue, but only on MacOS regardless of whether jemalloc was bundled. On Linux, I was not able to reproduce this issue.

@brianwyka
Copy link
Contributor

@lnkuiper , do you have instructions on how to bundle it? Perhaps I can contribute if its not on the roadmap or radar.

@lnkuiper
Copy link
Contributor

lnkuiper commented Aug 26, 2024

You can enable jemalloc by adding it to the list of extensions in vendor.py and calling python3 scripts/vendor.py --duckdb=/path/to/duckdb/repo, and then make release in duckdb-jdbc repo.

For other clients, we only bundle jemalloc on x86 linux, and we'd like to keep it the same for JDBC, so it needs to check this. You can check how we do this in duckdb repo at tools/pythonpkg/setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants