Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie banner #9

Open
dheurlin opened this issue Jul 16, 2019 · 3 comments
Open

Add cookie banner #9

dheurlin opened this issue Jul 16, 2019 · 3 comments

Comments

@dheurlin
Copy link
Collaborator

The site uses cookies apparently, so we should either add an annoying cookie banner or try to nuke the cookies

@viktorhallen
Copy link
Member

I vote nuke cookies. Those banners are the worst, and it's not like we use cookies for anything, right?

If we do use cookies for stuff, and instead switch to local storage, do we have to display a banner?

@Rembane
Copy link

Rembane commented Jul 17, 2019

I also vote nuke cookies to the extent it is possible. What cookies do we use and when?

Here is quite good information about the cookie law: https://webbriktlinjer.se/lagkrav/kaklagen-i-praktiken/ A relevant part is that we might not need to nuke all cookies. And that all ways to track users are covered by the law, so we cannot simply change to LocalStorage and say that we're compliant without getting consent from the users.

@Kirens
Copy link
Member

Kirens commented Jul 17, 2019

I think the cookies mainly are used to select language, which would be fine. Although I'd also vote to try to nuke 'em if it's not to complicated. I mean we could use the path or sub-domains to select locale.

Or are cookies preferable over path to set the locale?
Pros of cookies:

  • A Swedish user shares a site to an English speaker and both get their preferred language.
    Pros of path/domain:
  • Both languages are more easily crawlable.

Are there more things to consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants