Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving back to yaml.full_load for matrix metadata #839

Open
shaycrk opened this issue Mar 30, 2021 · 0 comments
Open

Consider moving back to yaml.full_load for matrix metadata #839

shaycrk opened this issue Mar 30, 2021 · 0 comments
Labels
needs-discussion

Comments

@shaycrk
Copy link
Contributor

shaycrk commented Mar 30, 2021

See discussion associated with #835

We switched to yaml.load when upgrading pyYAML to 5.4; moving back to full_load would provide some security enhancements but require changing how we represent as_of_time and feature lists in a way that would break compatibility with matrices generated by previous versions of triage, so we should decide if the improvements outweigh that cost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shaycrk