Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dscom BuildTask And use CLI Only #280

Open
carstencodes opened this issue Sep 25, 2024 · 0 comments
Open

Remove dscom BuildTask And use CLI Only #280

carstencodes opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@carstencodes
Copy link
Member

As observed in #104, MsBuild does not play well with the DsCom Library hosted within the MsBuild Tool.

We kept the task to investigate the issue more further, but forgot to removed it when closing #104.

In #278 @bclothier stated corerctly, if the task is not supported, it should be removed from source code and documentation:

FYI the documentation seems to imply that both are in use, that the client tool would be only used if 32-bit target is selected. On the review, and if I understand you correctly, the client tool is currently always used and the build task is never used unless I pass false explicitly to the "private" property _DsComForceToolUsage which the documentation does explicitly say to not do.

I think the documentation should be updated to indicate that client tool is always used. > In particular this passage:

dscom/README.md

Lines 241 to 245 in 869f481

The native build task is automatically selected, if a .NET 4.8 or .NET 6.0 assembly for Windows is being build using an x64 platform.
#### Using the CLI based task
The CLI task is automatically selected, if a .NET Standard 2.0 assembly is build. It is also chosen, if the target platform is set to x86.


Originally posted by @bclothier in #278 (comment)

@carstencodes carstencodes self-assigned this Sep 25, 2024
@carstencodes carstencodes added bug Something isn't working documentation Improvements or additions to documentation labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant