Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching map images #14

Open
dshepsis opened this issue Apr 29, 2021 · 3 comments
Open

Switching map images #14

dshepsis opened this issue Apr 29, 2021 · 3 comments
Labels
Leaflet Map Pertaining to the leaflet map To Do Planned to be implemented

Comments

@dshepsis
Copy link
Owner

Some physical maps (like, continuous loaded areas with a discrete map ID) have multiple map images associated for them. This includes things like dungeons (one map for each floor), North Ryo (inland map and island map), and various maps which change slightly over the story. There are also some distinct maps with separate ID's which actually refer to the same real area (e.g. Kamiki before and after the full moon festival) where stuff like treasures and animals are all the same. There should be some way to swap between the images for these different maps without changing the markers.

@dshepsis dshepsis added To Do Planned to be implemented Leaflet Map Pertaining to the leaflet map labels Apr 29, 2021
@zysim
Copy link
Contributor

zysim commented Jul 25, 2021

I would also add to this issue that switching between maps takes a bit longer to load than the markers themselves. Would need to show the user that the image is currently loading, or better yet, prefetch stuff.

@dshepsis
Copy link
Owner Author

This issue is mostly resolved as of 84c2d4d, with the exception of kamiki r102 vs r112 and dungeons. Giving feedback for loading images is a separate issue, but I agree that it should probably be done. I'm not sure how we would prefetch map images, since the user can switch from any map to any other.

@zysim
Copy link
Contributor

zysim commented Jul 25, 2021

I'll discuss stuff in a new issue for feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Leaflet Map Pertaining to the leaflet map To Do Planned to be implemented
Projects
None yet
Development

No branches or pull requests

2 participants