Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzDevOpsProject: Remove unnecessary property declaration #30

Open
johlju opened this issue Jan 31, 2021 · 1 comment
Open

AzDevOpsProject: Remove unnecessary property declaration #30

johlju opened this issue Jan 31, 2021 · 1 comment
Labels
Backlog - Mid Term Backlog - Mid Term enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Jan 31, 2021

Suggest we should remove the Mandatory from the key property as Key is implicitly mandatory.

AzureDevOpsDsc/source/Classes/010.AzDevOpsProject.ps1

Line 27 in f1d8097

[DscProperty(Key, Mandatory)]

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jan 31, 2021
@johlju
Copy link
Member Author

johlju commented Jan 31, 2021

This is just a style guideline thing. Tracking it in issue #29 too.

@kilasuit kilasuit added the Backlog - Mid Term Backlog - Mid Term label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backlog - Mid Term Backlog - Mid Term enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kilasuit @johlju