Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old node-fetch dependency chain causing deprecation error #1143

Open
Downchuck opened this issue Sep 8, 2024 · 3 comments
Open

Old node-fetch dependency chain causing deprecation error #1143

Downchuck opened this issue Sep 8, 2024 · 3 comments
Labels

Comments

@Downchuck
Copy link

The latest SDK is a bit long in the tooth - the node-fetch requirement is dated and in the dependency chain causes a deprecation warning from the yarn package manager.

While that node-fetch package could be bumped to something more current, or ade optional per #1130 the use of built-in fetch may have some challenges.

So, as a workaround for yarn users, this one can help:

  "resolutions": {
    "whatwg-url": "14.0.0 "
  },
@Downchuck Downchuck added the bug label Sep 8, 2024
@greg-db
Copy link
Contributor

greg-db commented Sep 9, 2024

Thanks for sharing this! I'll ask the team to update the SDK to address this.

@unilynx
Copy link

unilynx commented Oct 16, 2024

For NPM the equivalent workaround is adding an overrides key to package.json:

  "overrides": {
    "whatwg-url": "14.0.0"
  }

I don't know how far back the SDK wants to go with node support, but modern nodes ship with built-in fetch so the SDK might consider completely eliminating the dependency

@greg-db
Copy link
Contributor

greg-db commented Oct 16, 2024

Thanks for the information!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants