Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error when connection dropped, causing uploads to hang forever. #1078

Open
mixo-marcus opened this issue Feb 23, 2023 · 2 comments
Open
Labels

Comments

@mixo-marcus
Copy link

When uploading a file and the internet drops, an upload can hang for ever.

If we get ECONRESET or ENOTFOUND or ECONNREFUSED or EPIPE errors we can of course handle these and retry.

However sometimes we don't get any of these, and there is nothing returned so we can't handle and try again.

Has anyone experienced this and have a solution?

Thanks :-)

@mixo-marcus
Copy link
Author

To clarify these are the errors we're handling atm:
eMsg.includes('ECONNREFUSED') || eMsg.includes('EPIPE') || eMsg.includes('ENETUNREACH') || eMsg.includes('ENOTFOUND') || eMsg.includes('ETIMEDOUT') || e.status === 408 || e.status === 500

@greg-db
Copy link
Contributor

greg-db commented Feb 23, 2023

Thanks for the report! Unfortunately I don't have a solution for that, but I'll share this with the team to see if there's something we can do about that sort of scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants