Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow query params on delete requests #29

Closed
dpup opened this issue May 30, 2024 · 0 comments · Fixed by #30
Closed

Allow query params on delete requests #29

dpup opened this issue May 30, 2024 · 0 comments · Fixed by #30
Assignees
@dpup
Labels
bug Something isn't working

Comments

@dpup
Copy link
Owner

dpup commented May 30, 2024

From: grpc-ecosystem#30

renderURL will only add query params to GET requests. The gateway allows this.
@dpup dpup added the bug Something isn't working label May 30, 2024
@dpup dpup self-assigned this May 30, 2024
dpup added a commit that referenced this issue May 30, 2024
@dpup
Support query params on DELETE requests, closes #29
0047159
@dpup dpup mentioned this issue May 30, 2024
Merged
@dpup dpup closed this as completed in #30 May 31, 2024
dpup added a commit that referenced this issue May 31, 2024
@dpup
Support query params on DELETE requests, closes #29
ef9f14b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpup dpup

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support query params on DELETE requests, closes #29 dpup/protoc-gen-grpc-gateway-ts
1 participant
@dpup