Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command to register issue fork remote and checkout branch if MR does not exist. #28

Open
mglaman opened this issue Sep 2, 2021 · 2 comments

Comments

@mglaman
Copy link

mglaman commented Sep 2, 2021

Finally trying this out :)

I have a habit of making an issue fork and doing work before opening an MR. However, an error pops if the MR doesn't exist:

dogit issue:mr 3230959

Screen Shot 2021-09-01 at 9 03 22 PM

It'd be great if it could set everything up even if an MR doesn't exist, yet.

@dpi
Copy link
Owner

dpi commented Sep 2, 2021

Absolutely, this is a great idea for enhancement.

Theres some blockers though

  • To date the app doesnt mutate/modify any data on d.o. so some extra bits and safety will be needed.
  • Authentication will need to be a thing, inc TFA?
  • Is there a way to do everything we need just by interacting with Gitlab? Can we use Gitlabs access tokens? The UI's are disabled for creating Personal Tokens but we may be able to use them via API only? Needs investigation. Project access tokens are accessible? Usable?

@Berdir
Copy link

Berdir commented Nov 6, 2023

I'm not sure if any of that is necessary?

I don't think the question is to make any changes. Thsi is after clicking the issue fork button, the branch does exist and the drupal.org UI knows it and shows it, it's just not yet an MR.

So IMHO, despite then being slightly incorrectly named, issue:mr could be extended to, if there are no open merge requests, fall back to branches on that issue fork and allow to pick one of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants