From 3b5f0f4f9c38daefdd38c75a982523e0ccdd38a9 Mon Sep 17 00:00:00 2001
From: John Judd <john.judd@c2fo.com>
Date: Fri, 21 Jul 2023 18:38:23 -0500
Subject: [PATCH] address revive linter issues

---
 .golangci.yml  |  2 --
 expressions.go | 14 +++++++-------
 issues_test.go |  2 +-
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index 9b7e5217..6356653d 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -25,8 +25,6 @@ linters-settings:
     min-complexity: 20
   goimports:
     local-prefixes: github.com/golangci/golangci-lint
-  golint:
-    min-confidence: 0
   gomnd:
     settings:
       mnd:
diff --git a/expressions.go b/expressions.go
index 3bfa58b4..2b1eb23a 100644
--- a/expressions.go
+++ b/expressions.go
@@ -133,7 +133,7 @@ func COALESCE(vals ...interface{}) exp.SQLFunctionExpression {
 	return Func("COALESCE", vals...)
 }
 
-//nolint:stylecheck,golint // sql function name
+//nolint:stylecheck,revive // sql function name
 func ROW_NUMBER() exp.SQLFunctionExpression {
 	return Func("ROW_NUMBER")
 }
@@ -142,17 +142,17 @@ func RANK() exp.SQLFunctionExpression {
 	return Func("RANK")
 }
 
-//nolint:stylecheck,golint // sql function name
+//nolint:stylecheck,revive // sql function name
 func DENSE_RANK() exp.SQLFunctionExpression {
 	return Func("DENSE_RANK")
 }
 
-//nolint:stylecheck,golint // sql function name
+//nolint:stylecheck,revive // sql function name
 func PERCENT_RANK() exp.SQLFunctionExpression {
 	return Func("PERCENT_RANK")
 }
 
-//nolint:stylecheck,golint //sql function name
+//nolint:stylecheck,revive //sql function name
 func CUME_DIST() exp.SQLFunctionExpression {
 	return Func("CUME_DIST")
 }
@@ -161,17 +161,17 @@ func NTILE(n int) exp.SQLFunctionExpression {
 	return Func("NTILE", n)
 }
 
-//nolint:stylecheck,golint //sql function name
+//nolint:stylecheck,revive //sql function name
 func FIRST_VALUE(val interface{}) exp.SQLFunctionExpression {
 	return newIdentifierFunc("FIRST_VALUE", val)
 }
 
-//nolint:stylecheck,golint //sql function name
+//nolint:stylecheck,revive //sql function name
 func LAST_VALUE(val interface{}) exp.SQLFunctionExpression {
 	return newIdentifierFunc("LAST_VALUE", val)
 }
 
-//nolint:stylecheck,golint //sql function name
+//nolint:stylecheck,revive //sql function name
 func NTH_VALUE(val interface{}, nth int) exp.SQLFunctionExpression {
 	if s, ok := val.(string); ok {
 		val = I(s)
diff --git a/issues_test.go b/issues_test.go
index 18af9f23..f1375368 100644
--- a/issues_test.go
+++ b/issues_test.go
@@ -17,7 +17,7 @@ type githubIssuesSuite struct {
 	suite.Suite
 }
 
-func (gis *githubIssuesSuite) AfterTest(suiteName, testName string) {
+func (gis *githubIssuesSuite) AfterTest(_, _ string) {
 	goqu.SetColumnRenameFunction(strings.ToLower)
 }