Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all services inside docker-compose #147

Open
Tyrrrz opened this issue May 14, 2021 · 5 comments
Open

Put all services inside docker-compose #147

Tyrrrz opened this issue May 14, 2021 · 5 comments

Comments

@Tyrrrz
Copy link
Contributor

Tyrrrz commented May 14, 2021

Currently, only postgres and rabbitmq are included in docker-compose.yml. It would be extremely convenient for new contributors if that also contained frontend/backend/worker services as well.

@joaopgrassi
Copy link
Member

joaopgrassi commented May 14, 2021

I guess it depends on which part of the project you are working on. If you are working on the front-end, then it's only necessary to run the db+api. So maybe we could have multiple compose files that makes sense for each contributor "area"?

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented May 14, 2021

You can actually have one compose file, but then do docker-compose up service1 service2 to selectively run services, it's quite convenient. The default would be to run them all, but if you're working on one of the services you can selectively exclude it and run everything else.

@joaopgrassi
Copy link
Member

joaopgrassi commented May 14, 2021

Yep, that also works. One "downside" of this approach is that I have to remember to type all the services I need so 😄. Wheres if we have the individual compose-spa then I can just run that. Lazy I know.. Either way it's an improvement from what we have today hehe.

@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented May 15, 2021

You could probably also implement compose-without-frontend and compose-without-backend as batch files/shell scripts.

@joaopgrassi
Copy link
Member

Good idea! That would be the best of both worlds then :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants