Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn support #8

Open
duboff opened this issue Dec 30, 2016 · 1 comment
Open

Yarn support #8

duboff opened this issue Dec 30, 2016 · 1 comment

Comments

@duboff
Copy link

duboff commented Dec 30, 2016

Hi, we love Doppins but since switching to https://github.com/yarnpkg/yarn it has become a bit of a pain since Doppins does not update the lockfile. A solution would be to run yarn command for every PR.

I wanted to open a PR myself but couldn't so far figure out where this code should go.

@ekmartin
Copy link
Member

Sorry for the late reply. This is definitely something we want to support however, and we've discussed it previously. Optimally we'd only want a PR to include changes to yarn.lock related to the dependency it tries to upgrade. I.e. if a PR upgrades express it shouldn't update the version for transient dependencies not created by express.

I think this might be achieved by using yarn upgrade [email protected], but have to verify that it doesn't make other changes to the lock file as well. The problem with this however is that it requires yarn to actually install the dependencies, something we'd rather avoid if possible. I'm not sure if it's possible to generate yarn lock-files without actually installing dependencies though - will have to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants