Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] go: binlogreplication: tests: Parallelize the test suite, slightly improve process management. #8805

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Jan 31, 2025

Move the global state to a harness struct, and change all interactions to go through the harness, so that we can run these tests in parallel.

We also clean up the process management a bit, since it was subject to leaving straggling sql-server and mysqld instances for me, usually because I would ^C it when it took too long after I ran go test ./.... The two major changes are:

  1. In the happy case, we now gracefully terminate the child and assert that it exited success.

  2. We now explicitly try to get helpful signals to all children when the test binary itself receives a SIGINT.

… suite, slightly improve process management.

Move the global state to a harness struct, and change all interactions to go
through the harness, so that we can run these tests in parallel.

We also clean up the process management a bit, since it was subject to leaving
straggling sql-server and mysqld instances for me, usually because I would ^C
it when it took too long after I ran `go test ./...`. The two major changes
are:

1) In the happy case, we now gracefully terminate the child and assert that it
exited success.

2) We now explicitly try to get helpful signals to all children when the test
binary itself receives a SIGINT.
@reltuk reltuk requested a review from fulghum January 31, 2025 21:22
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f131fb8 ok 5937457
version total_tests
f131fb8 5937457
correctness_percentage
100.0

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@reltuk reltuk merged commit ed1af8f into main Jan 31, 2025
21 of 22 checks passed
Copy link

github-actions bot commented Feb 1, 2025

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.14
batching batch sql 10000 1 0.09 1.33
batching by line sql 10000 1 0.1 1.2
blob 1 blob 200000 1 0.92 3.84 4.6
blob 2 blobs 200000 1 0.94 4.23 4.69
blob no blob 200000 1 1 2.21 2.6
col type datetime 200000 1 0.83 2.42 2.72
col type varchar 200000 1 0.77 3.19 3.53
config width 2 cols 200000 1 0.97 2.07 2.36
config width 32 cols 200000 1 1.92 2.03 2.73
config width 8 cols 200000 1 1.02 2.3 2.57
pk type float 200000 1 0.94 2.24 2.48
pk type int 200000 1 0.93 2.16 2.44
pk type varchar 200000 1 3.07 0.92 0.91
row count 1.6mm 1600000 1 5.96 2.83 2.78
row count 400k 400000 1 1.47 2.8 2.95
row count 800k 800000 1 2.97 2.8 2.82
secondary index four index 200000 1 3.69 1.34 1.27
secondary index no secondary 200000 1 0.99 2.21 2.66
secondary index one index 200000 1 1.17 2.38 2.48
secondary index two index 200000 1 2.01 1.78 1.86
sorting shuffled 1mm 1000000 0 5.53 2.73 2.59
sorting sorted 1mm 1000000 1 5.36 2.8 2.7

Copy link

github-actions bot commented Feb 1, 2025

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.22
dolt_blame_commit_filter system table 2.98
dolt_commit_ancestors_commit_filter system table 0.65
dolt_commits_commit_filter system table 1.11
dolt_diff_log_join_from_commit system table 2.84
dolt_diff_log_join_to_commit system table 2.82
dolt_diff_table_from_commit_filter system table 1.24
dolt_diff_table_to_commit_filter system table 1.14
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.36
dolt_log_commit_filter system table 1.16

Copy link

github-actions bot commented Feb 1, 2025

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 1.12
adds_updates_deletes 60000 60000 60000 4.61
deletes_only 0 60000 0 2.42
updates_only 0 0 60000 3.05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants