Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include deleteErr message in returned error #8804

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Include deleteErr message in returned error #8804

merged 1 commit into from
Jan 31, 2025

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 31, 2025

No description provided.

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3821a7a ok 5937457
version total_tests
3821a7a 5937457
correctness_percentage
100.0

jycor
jycor approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulghum fulghum merged commit 84bd03d into main Jan 31, 2025
34 of 35 checks passed
@fulghum fulghum deleted the fulghum/delete-err branch January 31, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fulghum @coffeegoddd @jycor