Reuse account between multiples apps #211
Conversation
…ey.json and account_reg.json files if available.
bjelline
changed the title
|
👍 i like the fact its optional based on the existence of the files in the dokku home dir. However i'd also still like to disable the reuse of the files are there... (i.e. put the check behind a flag |
|
@fruitl00p : you're right, there is a need for separate accounts. We already have the variable DOKKU_LETSENCRYPT_EMAIL, the account should probably be linked to the value of this variable... |
|
@bjelline looks good so far, please re-comment when the feedback from @fruitl00p gets implemented :) |
|
in this version the accounts are linked to the value of DOKKU_LETSENCRYPT_EMAIL: when dokku letsencrypt is called, we look through the other apps to find one that |
|
I don't think we should fetch the env vars like that - manually parsing the env isn't great. Can you switch that to using the Additionally, would you be able to gate this behind a flag, as mentioned by @fruitl00p ? |
|
Going to close this. We'll need to redo this once the acme/lego switch gets merged. Thanks for the initial PR though! |
Fixes #158
To avoid generating a new account for every app we must
supply the files
account_key.jsonandaccount_reg.jsonwhen the simp_le docker image is run.
If we don't supply them a new account and new files
account_key.jsonandaccount_reg.jsonare created.
If you have already used
dokku letsencryptsucessfully once you cancopy the two files from /home/dokku/APPNAME/letsencrypt/certs/current/ to /home/dokku/
then each subsequent run of
dokku letsencryptwill pick them up and copythem over to the new apps configuration. The account will be reused
and you will not run into the "too many accounts created" rate limit of letsencrypt