Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce all exceptions to DokanyException only? #31

Open
hrstoyanov opened this issue Jan 28, 2020 · 1 comment
Open

Reduce all exceptions to DokanyException only? #31

hrstoyanov opened this issue Jan 28, 2020 · 1 comment
Milestone

Comments

@hrstoyanov
Copy link

What if we eliminate LibraryNotFoundException, MountFailedException, UnmountFailedException and just use DokanyException - they are all essentially the same? This would shrink the dokan-java API surface further, but would probably need to be a major new version, as it is not backward compatible..

@infeo infeo added this to the 2.0 milestone May 21, 2020
@infeo
Copy link
Member

infeo commented May 21, 2020

I'll agree with you, that the exceptions need a refactoring.

I like the suggestion made in this SO post to create an own exception class and either wrap all occuring exceptions or extend from this base class. Especially in the second case the developer can catch more specific exceptions if they want to, or just catch the generic one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants