Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCE support in the SDK #333

Open
nicolassanmar opened this issue Aug 24, 2023 · 2 comments
Open

PKCE support in the SDK #333

nicolassanmar opened this issue Aug 24, 2023 · 2 comments
Assignees

Comments

@nicolassanmar
Copy link

DocuSign now supports PKCE since March 2023 https://www.docusign.com/blog/developers/docusign-adds-support-pkce.
Unfortunately there is no way to make use of PKCE using the SDK, and I have not found workarounds.

We should add PKCE support to the SDK, and here are two different ways to do so:

  1. Abstract away PKCE by adding an initialization option enablePKCE: true to the ApiClient constructor, where code_challenge and code_verifier are added to requests under the hood.
  2. Add optional parameters to authentication functions to allow us to send our own code_challenge and code_verifier in each relevant call.
@ByungjaeChung
Copy link

DocuSign does not support Authorization Code Grant in our SDKs since it is webstack dependent. Instead, a generic (not DocuSign specific) OAuth library should always be used. Node for example is usually used with Passport. Some support PKCE, others do not.

@jmsrpp
Copy link

jmsrpp commented Aug 5, 2024

It would be acceptable for an additional optional parameter object to requestJWTUserToken (and ACG equivalent) where we can fill in the code_challenge and code_verifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants