Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phoneNumber for Signer parameter is not in @types package #318

Open
peiofour opened this issue Jan 17, 2023 · 8 comments
Open

phoneNumber for Signer parameter is not in @types package #318

peiofour opened this issue Jan 17, 2023 · 8 comments

Comments

@peiofour
Copy link

Hello DocuSign,

I work on a project using the docusign-esign 5.20.0 npm package and its types package 5.19.0.
Using the Signer class, I noticed that my linter doesn't accept the phoneNumber parameter. I checked on the types docusign-esign package, it is not in the Signer interface.

image

Is the types package not updated or is the parameter deprecated?

Thanks in advance!

@InbarGazit
Copy link
Member

This is the old way to do this, this has moved under workflow.
See full code in https://github.com/docusign/code-examples-node/blob/master/lib/eSignature/examples/phoneAuthentication.js


  let signer1 = docusign.Signer.constructFromObject({
    email: args.signerEmail,
    name: args.signerName,
    recipientId: RecipientId,
    routingOrder: "1",
    deliveryMethod: "Email",
    tabs: signer1Tabs,
    identityVerification: { workflowId: args.workflowId, steps: null, "inputOptions":[{"name":"phone_number_list","valueType":"PhoneNumberList","phoneNumberList":[{"countryCode":args.countryCode,"code":"1","number":args.phoneNumber}]}], "idCheckConfigurationName":""}
  });

@peiofour
Copy link
Author

@acooper4960
Copy link
Contributor

acooper4960 commented Jan 24, 2023

@peiofour for the most up-to-date reference for this SDK, please refer to http://docusign.github.io/docusign-esign-node-client. These get automatically updated during our release process and will be the most consistent reference to the SDK

@InbarGazit
Copy link
Member

@peiofour I'm confused, is this about SMS delivery or SMS authentication? these are two different things.

@peiofour
Copy link
Author

@InbarGazit
Copy link
Member

OK, thanks, do you still have an issue? or can I close this out?

@peiofour
Copy link
Author

peiofour commented Feb 1, 2023

Yes ! The issue didn't change, tslint does'nt accept phoneNumber parameter as we can see here : https://developers.docusign.com/docs/esign-rest-api/esign101/concepts/sms-delivery/

image

@Olexandr-Liaguta
Copy link

And there is no additionalNotifications field for the Signer type
Screenshot 2024-09-04 at 13 56 57
Screenshot 2024-09-04 at 13 57 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants