From 3a827f367bc0be0b38abdd0f290538fac05015f5 Mon Sep 17 00:00:00 2001 From: Shane Archer Date: Mon, 2 Nov 2015 11:06:08 -0800 Subject: [PATCH] Style correction and fix to existing test. --- .../ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelper.php | 2 -- .../Tests/ODM/PHPCR/Functional/QueryBuilderTest.php | 6 +++--- .../ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelperTest.php | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/Doctrine/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelper.php b/lib/Doctrine/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelper.php index 913324f3c..9063dfedb 100644 --- a/lib/Doctrine/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelper.php +++ b/lib/Doctrine/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelper.php @@ -57,14 +57,12 @@ public static function checkNodeTypeMappings(DocumentManagerInterface $documentM $knownNodeTypes[$classMetadata->getNodeType()] = $classMetadata->name; if (!is_null($output)) { - $output->writeln(sprintf( 'The document %s uses %snode type %s', $classMetadata->name, $classMetadata->hasUniqueNodeType() ? 'uniquely mapped ' : '', $classMetadata->getNodeType() )); - } } } diff --git a/tests/Doctrine/Tests/ODM/PHPCR/Functional/QueryBuilderTest.php b/tests/Doctrine/Tests/ODM/PHPCR/Functional/QueryBuilderTest.php index 1ed446210..e6b4a22c6 100644 --- a/tests/Doctrine/Tests/ODM/PHPCR/Functional/QueryBuilderTest.php +++ b/tests/Doctrine/Tests/ODM/PHPCR/Functional/QueryBuilderTest.php @@ -176,7 +176,7 @@ public function testComposite() switch ($qb->getQuery()->getLanguage()) { case 'JCR-SQL2': - $query = "SELECT a.* FROM [nt:unstructured] AS a WHERE ((a.username = 'dtl' OR a.username = 'js') AND (a.[phpcr:class] = 'Doctrine\Tests\Models\Blog\User' OR a.[phpcr:classparents] = 'Doctrine\Tests\Models\Blog\User'))"; + $query = "SELECT a.* FROM [nt:unstructured] AS a WHERE ((a.[username] = 'dtl' OR a.[username] = 'js') AND (a.[phpcr:class] = 'Doctrine\Tests\Models\Blog\User' OR a.[phpcr:classparents] = 'Doctrine\Tests\Models\Blog\User'))"; break; case 'sql': $query = "SELECT s FROM nt:unstructured AS a WHERE (a.username = 'dtl' OR a,username = 'js')"; @@ -193,7 +193,7 @@ public function testComposite() switch ($qb->getQuery()->getLanguage()) { case 'JCR-SQL2': - $query = "SELECT a.* FROM [nt:unstructured] AS a WHERE (((a.username = 'dtl' OR a.username = 'js') AND a.name = 'foobar') AND (a.[phpcr:class] = 'Doctrine\Tests\Models\Blog\User' OR a.[phpcr:classparents] = 'Doctrine\Tests\Models\Blog\User'))"; + $query = "SELECT a.* FROM [nt:unstructured] AS a WHERE (((a.[username] = 'dtl' OR a.[username] = 'js') AND a.[name] = 'foobar') AND (a.[phpcr:class] = 'Doctrine\Tests\Models\Blog\User' OR a.[phpcr:classparents] = 'Doctrine\Tests\Models\Blog\User'))"; break; case 'sql': $this->markTestIncomplete('Not testing SQL for sql query language'); @@ -212,7 +212,7 @@ public function testComposite() switch ($qb->getQuery()->getLanguage()) { case 'JCR-SQL2': - $query = "SELECT a.* FROM [nt:unstructured] AS a WHERE ((((a.username = 'dtl' OR a.username = 'js') AND a.name = 'foobar') OR a.name = 'johnsmith') AND (a.[phpcr:class] = 'Doctrine\Tests\Models\Blog\User' OR a.[phpcr:classparents] = 'Doctrine\Tests\Models\Blog\User'))"; + $query = "SELECT a.* FROM [nt:unstructured] AS a WHERE ((((a.[username] = 'dtl' OR a.[username] = 'js') AND a.[name] = 'foobar') OR a.[name] = 'johnsmith') AND (a.[phpcr:class] = 'Doctrine\Tests\Models\Blog\User' OR a.[phpcr:classparents] = 'Doctrine\Tests\Models\Blog\User'))"; break; case 'sql': $this->markTestIncomplete('Not testing SQL for sql query language'); diff --git a/tests/Doctrine/Tests/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelperTest.php b/tests/Doctrine/Tests/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelperTest.php index 09c9dc2b7..f7ac6f903 100644 --- a/tests/Doctrine/Tests/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelperTest.php +++ b/tests/Doctrine/Tests/ODM/PHPCR/Tools/Helper/UniqueNodeTypeHelperTest.php @@ -95,4 +95,4 @@ public function testCheckNodeTypeMappingsWithoutDuplicate() UniqueNodeTypeHelper::checkNodeTypeMappings($documentManager); } -} \ No newline at end of file +}