Fixed #207 -- Add lint check on pre-commit for front end #251
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to Django India! 🎉🇮🇳
We're so happy to see you contribute. Your efforts mean a lot to us and we're excited to have you on this journey.
Before we proceed, please take a moment to review our contribution guide. It's packed with all the information you need to make your contribution seamless.
If you're fixing an issue from the Django India issue tracker, remember to get it assigned to you before you acutally start working on it.
If you ever need help or just want to chat, the Django India discord server is always open. We're here for you!
And while you're here, don't forget to ⭐ star our repo to show your support! It helps the community grow.
Thank you for being a part of Django India. Together, let's make an amazing community! 🚀
|
what are other options for lint and how prettier is better? |
other options we can use ESlint and TSlint , but prettier gave consistency and easy integration , i think so |
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v4.5.0 | ||
| hooks: | ||
| - id: check-yaml | ||
| - id: check-case-conflict | ||
| - id: check-json | ||
| - id: check-merge-conflict | ||
| - id: check-symlinks | ||
| - id: check-toml | ||
| - id: end-of-file-fixer | ||
| exclude: ^(frontend/|.*\.js$) | ||
| - id: requirements-txt-fixer | ||
| - id: detect-private-key | ||
| - repo: https://github.com/astral-sh/ruff-pre-commit |
There was a problem hiding this comment.
I think you have added unnecessary indentation in the existing pre-commit hooks 🤔
There was a problem hiding this comment.
actually , it was done by prettier itself
This PR updates the .pre-commit-config.yaml file to include Prettier for linting front-end code.
closes #207