Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obtaining Pack URL #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

1JackBlack1
Copy link

@1JackBlack1 1JackBlack1 commented May 22, 2021

Fixes #57 and corrects for a mistake in a previous commit (460ba5c) preventing using a directory other than the default while still providing a useful message.

@1JackBlack1 1JackBlack1 marked this pull request as ready for review May 22, 2021 12:02
@1JackBlack1
Copy link
Author

This removes the use of the now non-existent files table in the database to obtain the pack download URL.
Additionally, it also obtains a correct download URL to be able to download pack.zip.
This uses a method similar to finding the fileID for the latest mod version, but jumps straight to the download URL. Alternatively, a specific fileID can be specified, in which case it directly looks up the download URL based upon the projectID and fileID.

It also allows you to use a projectID instead of a slug.

Additionally, you can once again install a pack using a directory and manifest, or specifying a directory/custom name along with a slug/projectID. Now if none of those are provided it will provide an error message saying that it was unable to find the manifest and giving instructions on how to install with the same name and slug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File table not found
1 participant