Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get some Unit Tests and CI #11

Open
ccoffrin opened this issue Aug 12, 2016 · 5 comments
Open

Get some Unit Tests and CI #11

ccoffrin opened this issue Aug 12, 2016 · 5 comments

Comments

@ccoffrin
Copy link
Member

I could use some help. I have no idea how to test JS.

@ccoffrin ccoffrin changed the title Get some Unit Tests and CI on this repo... Get some Unit Tests and CI Aug 12, 2016
@Bluejay47
Copy link

I use Mocha but there are several other popular unit test systems. What did you have in mind as far as priorities for developing tests?

@ccoffrin
Copy link
Member Author

ccoffrin commented Sep 3, 2016

Nothing too major. In other code bases I try make some easy integration tests that emulate typical student interactions. Then use code coverage reports to make sure I have hit 80-90% of the code.

This is a good example,

https://github.com/discreteoptimization/assignment/blob/master/test/submit_test.py

I no nothing about JS unit testing frameworks or how to do CI outside the browser, so your experience would be much appreciated!

@Bluejay47
Copy link

Sure I can take a stab at it this weekend. Setting up the framework is fairly easy and Mocha is very straightforward.

@Bluejay47
Copy link

I am using mocha.js for testing and blanketjs for code coverage. Do you have a preference as to how to include these in the project? Do you want to continue to load external libraries from a CDN or would you prefer to move these libraries into the project using Bower?

@ccoffrin
Copy link
Member Author

In light of modern web tools, I am a web-dev novice; so I'll trust your judgement on this one.

My feeling is that it is best to load the libraries via a CDN. That way, it is one less tool that a would-be contributor would need to learn.

These are not mission critical tools so if the break due to an external library update that is not a huge deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants