forked from milestorme/cross-faction-dungeon-finder
-
Notifications
You must be signed in to change notification settings - Fork 0
/
cfbg.patch
536 lines (497 loc) · 25 KB
/
cfbg.patch
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
diff --git a/src/server/game/DungeonFinding/LFGMgr.cpp b/src/server/game/DungeonFinding/LFGMgr.cpp
index 95a7aec98f..992bf60ea7 100644
--- a/src/server/game/DungeonFinding/LFGMgr.cpp
+++ b/src/server/game/DungeonFinding/LFGMgr.cpp
@@ -1927,6 +1927,33 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
if (player->GetMapId() == uint32(dungeon->map))
player->TeleportToEntryPoint();
+ uint8 RealRace = player->getRace(true);
+
+ player->setRace(RealRace);
+ player->setTeamId(player->TeamIdForRace(RealRace));
+
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(RealRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
+
+ if (group)
+ {
+ for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
+ {
+ if (Player* player2 = itr->GetSource())
+ {
+ WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
+ Data << player2->GetGUID();
+ player->GetSession()->SendPacket(&Data);
+ player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
+
+ WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
+ Data2 << player->GetGUID();
+ player2->GetSession()->SendPacket(&Data2);
+ player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ }
+ }
+ }
+
return;
}
@@ -1971,7 +1998,36 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
if (!player->GetMap()->IsDungeon())
player->SetEntryPoint();
- if (!player->TeleportTo(mapid, x, y, z, orientation))
+ if (player->TeleportTo(mapid, x, y, z, orientation) && group)
+ {
+ if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
+ {
+ uint8 LeaderRace = leader->getRace();
+
+ player->setRace(LeaderRace);
+ player->setTeamId(leader->TeamIdForRace(LeaderRace));
+
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
+ }
+
+ for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
+ {
+ if (Player* player2 = itr->GetSource())
+ {
+ WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
+ Data << player2->GetGUID();
+ player->GetSession()->SendPacket(&Data);
+ player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
+
+ WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
+ Data2 << player->GetGUID();
+ player2->GetSession()->SendPacket(&Data2);
+ player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ }
+ }
+ }
+ else
error = LFG_TELEPORTERROR_INVALID_LOCATION;
}
else
@@ -2396,7 +2452,7 @@ void LFGMgr::SetLeader(uint64 gguid, uint64 leader)
void LFGMgr::SetTeam(uint64 guid, TeamId teamId)
{
- if (sWorld->getBoolConfig(CONFIG_ALLOW_TWO_SIDE_INTERACTION_GROUP))
+ if (sWorld->getBoolConfig(CONFIG_ALLOW_TWO_SIDE_INTERACTION_GROUP) || sWorld->getBoolConfig(CONFIG_ALLOW_CROSSFACTION_DUNGEON))
teamId = TEAM_ALLIANCE; // @Not Sure About That TeamId is supposed to be uint8 Team = 0(@TrinityCore)
PlayersStore[guid].SetTeam(teamId);
diff --git a/src/server/game/DungeonFinding/LFGScripts.cpp b/src/server/game/DungeonFinding/LFGScripts.cpp
index 31420b2475..49f94678b7 100644
--- a/src/server/game/DungeonFinding/LFGScripts.cpp
+++ b/src/server/game/DungeonFinding/LFGScripts.cpp
@@ -71,6 +71,35 @@ void LFGPlayerScript::OnLogin(Player* player)
// player->GetSession()->GetPlayerInfo().c_str(), GUID_LOPART(gguid2), GUID_LOPART(gguid));
sLFGMgr->SetupGroupMember(guid, group->GetGUID());
}
+
+ if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
+ {
+ uint8 LeaderRace = leader->getRace();
+
+ player->setRace(LeaderRace);
+ player->setTeamId(leader->TeamIdForRace(LeaderRace));
+
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
+ }
+
+ Group* group2 = player->GetGroup();
+
+ for (GroupReference* itr = group2->GetFirstMember(); itr != nullptr; itr = itr->next())
+ {
+ if (Player* player2 = itr->GetSource())
+ {
+ WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
+ Data << player2->GetGUID();
+ player->GetSession()->SendPacket(&Data);
+ player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
+
+ WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
+ Data2 << player->GetGUID();
+ player2->GetSession()->SendPacket(&Data2);
+ player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ }
+ }
}
sLFGMgr->InitializeLockedDungeons(player);
diff --git a/src/server/game/Handlers/ChatHandler.cpp b/src/server/game/Handlers/ChatHandler.cpp
index d70fb4ea39..a391c67436 100644
--- a/src/server/game/Handlers/ChatHandler.cpp
+++ b/src/server/game/Handlers/ChatHandler.cpp
@@ -352,6 +352,9 @@ void WorldSession::HandleMessagechatOpcode(WorldPacket & recvData)
return;
}
+ if (lang != LANG_ADDON && sender->GetMap()->IsDungeon())
+ lang = LANG_UNIVERSAL;
+
if (type == CHAT_MSG_SAY)
sender->Say(msg, lang);
else if (type == CHAT_MSG_EMOTE)
@@ -405,6 +408,9 @@ void WorldSession::HandleMessagechatOpcode(WorldPacket & recvData)
case CHAT_MSG_PARTY:
case CHAT_MSG_PARTY_LEADER:
{
+ if (lang != LANG_ADDON && sender->GetMap()->IsDungeon())
+ lang = LANG_UNIVERSAL;
+
// if player is in battleground, he cannot say to battleground members by /p
Group* group = GetPlayer()->GetOriginalGroup();
if (!group)
@@ -460,6 +466,9 @@ void WorldSession::HandleMessagechatOpcode(WorldPacket & recvData)
} break;
case CHAT_MSG_RAID:
{
+ if (lang != LANG_ADDON && sender->GetMap()->IsDungeon())
+ lang = LANG_UNIVERSAL;
+
// if player is in battleground, he cannot say to battleground members by /ra
Group* group = GetPlayer()->GetOriginalGroup();
if (!group)
@@ -480,6 +489,9 @@ void WorldSession::HandleMessagechatOpcode(WorldPacket & recvData)
} break;
case CHAT_MSG_RAID_LEADER:
{
+ if (lang != LANG_ADDON && sender->GetMap()->IsDungeon())
+ lang = LANG_UNIVERSAL;
+
// if player is in battleground, he cannot say to battleground members by /ra
Group* group = GetPlayer()->GetOriginalGroup();
if (!group)
@@ -500,6 +512,9 @@ void WorldSession::HandleMessagechatOpcode(WorldPacket & recvData)
} break;
case CHAT_MSG_RAID_WARNING:
{
+ if (lang != LANG_ADDON && sender->GetMap()->IsDungeon())
+ lang = LANG_UNIVERSAL;
+
Group* group = GetPlayer()->GetGroup();
if (!group || !group->isRaidGroup() || !(group->IsLeader(GetPlayer()->GetGUID()) || group->IsAssistant(GetPlayer()->GetGUID())) || group->isBGGroup())
return;
diff --git a/src/server/game/World/World.cpp b/src/server/game/World/World.cpp
index da62ad302f..546970adec 100644
--- a/src/server/game/World/World.cpp
+++ b/src/server/game/World/World.cpp
@@ -729,6 +729,7 @@ void World::LoadConfigSettings(bool reload)
m_bool_configs[CONFIG_ALLOW_TWO_SIDE_INTERACTION_CHAT] = sConfigMgr->GetBoolDefault("AllowTwoSide.Interaction.Chat", false);
m_bool_configs[CONFIG_ALLOW_TWO_SIDE_INTERACTION_CHANNEL] = sConfigMgr->GetBoolDefault("AllowTwoSide.Interaction.Channel", false);
m_bool_configs[CONFIG_ALLOW_TWO_SIDE_INTERACTION_GROUP] = sConfigMgr->GetBoolDefault("AllowTwoSide.Interaction.Group", false);
+ m_bool_configs[CONFIG_ALLOW_CROSSFACTION_DUNGEON] = sConfigMgr->GetBoolDefault("AllowTwoSide.DungeonFinder", false);
m_bool_configs[CONFIG_ALLOW_TWO_SIDE_INTERACTION_GUILD] = sConfigMgr->GetBoolDefault("AllowTwoSide.Interaction.Guild", false);
m_bool_configs[CONFIG_ALLOW_TWO_SIDE_INTERACTION_AUCTION] = sConfigMgr->GetBoolDefault("AllowTwoSide.Interaction.Auction", false);
m_bool_configs[CONFIG_ALLOW_TWO_SIDE_INTERACTION_MAIL] = sConfigMgr->GetBoolDefault("AllowTwoSide.Interaction.Mail", false);
diff --git a/src/server/game/World/World.h b/src/server/game/World/World.h
index 0b8269d4eb..02da76c0f8 100644
--- a/src/server/game/World/World.h
+++ b/src/server/game/World/World.h
@@ -84,6 +84,7 @@ enum WorldBoolConfigs
CONFIG_ALLOW_TWO_SIDE_INTERACTION_CHAT,
CONFIG_ALLOW_TWO_SIDE_INTERACTION_CHANNEL,
CONFIG_ALLOW_TWO_SIDE_INTERACTION_GROUP,
+ CONFIG_ALLOW_CROSSFACTION_DUNGEON,
CONFIG_ALLOW_TWO_SIDE_INTERACTION_GUILD,
CONFIG_ALLOW_TWO_SIDE_INTERACTION_AUCTION,
CONFIG_ALLOW_TWO_SIDE_INTERACTION_MAIL,
diff --git a/src/server/worldserver/worldserver.conf.dist b/src/server/worldserver/worldserver.conf.dist
index 869a46d49b..395953dd0c 100644
--- a/src/server/worldserver/worldserver.conf.dist
+++ b/src/server/worldserver/worldserver.conf.dist
@@ -1649,6 +1649,14 @@ AllowTwoSide.Interaction.Channel = 0
AllowTwoSide.Interaction.Group = 0
+#
+# AllowTwoSide.DungeonFinder
+# Description: Allow both side joining dungeon between factions.
+# Default: 0 - (Disabled)
+# 1 - (Enabled)
+
+AllowTwoSide.DungeonFinder = 0
+
#
# AllowTwoSide.Interaction.Guild
# Description: Allow guild joining between factions.
diff --git a/src/server/game/DungeonFinding/LFGMgr.cpp b/src/server/game/DungeonFinding/LFGMgr.cpp
index 992bf60ea7..e8c5f2e1bb 100644
--- a/src/server/game/DungeonFinding/LFGMgr.cpp
+++ b/src/server/game/DungeonFinding/LFGMgr.cpp
@@ -1927,29 +1927,32 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
if (player->GetMapId() == uint32(dungeon->map))
player->TeleportToEntryPoint();
- uint8 RealRace = player->getRace(true);
+ if (sWorld->getBoolConfig(CONFIG_ALLOW_CROSSFACTION_DUNGEON))
+ {
+ uint8 RealRace = player->getRace(true);
- player->setRace(RealRace);
- player->setTeamId(player->TeamIdForRace(RealRace));
+ player->setRace(RealRace);
+ player->setTeamId(player->TeamIdForRace(RealRace));
- ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(RealRace);
- player->setFaction(CharRace ? CharRace->FactionID : 0);
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(RealRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
- if (group)
- {
- for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
+ if (group)
{
- if (Player* player2 = itr->GetSource())
+ for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
{
- WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
- Data << player2->GetGUID();
- player->GetSession()->SendPacket(&Data);
- player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
-
- WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
- Data2 << player->GetGUID();
- player2->GetSession()->SendPacket(&Data2);
- player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ if (Player* player2 = itr->GetSource())
+ {
+ WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
+ Data << player2->GetGUID();
+ player->GetSession()->SendPacket(&Data);
+ player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
+
+ WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
+ Data2 << player->GetGUID();
+ player2->GetSession()->SendPacket(&Data2);
+ player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ }
}
}
}
@@ -1998,32 +2001,35 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
if (!player->GetMap()->IsDungeon())
player->SetEntryPoint();
- if (player->TeleportTo(mapid, x, y, z, orientation) && group)
+ if (player->TeleportTo(mapid, x, y, z, orientation))
{
- if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
+ if (group && sWorld->getBoolConfig(CONFIG_ALLOW_CROSSFACTION_DUNGEON))
{
- uint8 LeaderRace = leader->getRace();
+ if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
+ {
+ uint8 LeaderRace = leader->getRace();
- player->setRace(LeaderRace);
- player->setTeamId(leader->TeamIdForRace(LeaderRace));
+ player->setRace(LeaderRace);
+ player->setTeamId(leader->TeamIdForRace(LeaderRace));
- ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
- player->setFaction(CharRace ? CharRace->FactionID : 0);
- }
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
+ }
- for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
- {
- if (Player* player2 = itr->GetSource())
+ for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
{
- WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
- Data << player2->GetGUID();
- player->GetSession()->SendPacket(&Data);
- player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
-
- WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
- Data2 << player->GetGUID();
- player2->GetSession()->SendPacket(&Data2);
- player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ if (Player* player2 = itr->GetSource())
+ {
+ WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
+ Data << player2->GetGUID();
+ player->GetSession()->SendPacket(&Data);
+ player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
+
+ WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
+ Data2 << player->GetGUID();
+ player2->GetSession()->SendPacket(&Data2);
+ player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ }
}
}
}
diff --git a/src/server/game/DungeonFinding/LFGScripts.cpp b/src/server/game/DungeonFinding/LFGScripts.cpp
index 49f94678b7..4d715101f1 100644
--- a/src/server/game/DungeonFinding/LFGScripts.cpp
+++ b/src/server/game/DungeonFinding/LFGScripts.cpp
@@ -72,32 +72,35 @@ void LFGPlayerScript::OnLogin(Player* player)
sLFGMgr->SetupGroupMember(guid, group->GetGUID());
}
- if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
+ if (sWorld->getBoolConfig(CONFIG_ALLOW_CROSSFACTION_DUNGEON))
{
- uint8 LeaderRace = leader->getRace();
+ if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
+ {
+ uint8 LeaderRace = leader->getRace();
- player->setRace(LeaderRace);
- player->setTeamId(leader->TeamIdForRace(LeaderRace));
+ player->setRace(LeaderRace);
+ player->setTeamId(leader->TeamIdForRace(LeaderRace));
- ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
- player->setFaction(CharRace ? CharRace->FactionID : 0);
- }
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
+ }
- Group* group2 = player->GetGroup();
+ Group* group2 = player->GetGroup();
- for (GroupReference* itr = group2->GetFirstMember(); itr != nullptr; itr = itr->next())
- {
- if (Player* player2 = itr->GetSource())
+ for (GroupReference* itr = group2->GetFirstMember(); itr != nullptr; itr = itr->next())
{
- WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
- Data << player2->GetGUID();
- player->GetSession()->SendPacket(&Data);
- player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
-
- WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
- Data2 << player->GetGUID();
- player2->GetSession()->SendPacket(&Data2);
- player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ if (Player* player2 = itr->GetSource())
+ {
+ WorldPacket Data(SMSG_INVALIDATE_PLAYER, 8);
+ Data << player2->GetGUID();
+ player->GetSession()->SendPacket(&Data);
+ player->GetSession()->SendNameQueryOpcode(player2->GetGUID());
+
+ WorldPacket Data2(SMSG_INVALIDATE_PLAYER, 8);
+ Data2 << player->GetGUID();
+ player2->GetSession()->SendPacket(&Data2);
+ player2->GetSession()->SendNameQueryOpcode(player->GetGUID());
+ }
}
}
}
diff --git a/src/server/game/DungeonFinding/LFGMgr.cpp b/src/server/game/DungeonFinding/LFGMgr.cpp
index e8c5f2e1bb..d9c0b86814 100644
--- a/src/server/game/DungeonFinding/LFGMgr.cpp
+++ b/src/server/game/DungeonFinding/LFGMgr.cpp
@@ -1933,9 +1933,7 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
player->setRace(RealRace);
player->setTeamId(player->TeamIdForRace(RealRace));
-
- ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(RealRace);
- player->setFaction(CharRace ? CharRace->FactionID : 0);
+ player->setFaction(player->OldFactionID);
if (group)
{
@@ -2007,13 +2005,17 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
{
if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
{
- uint8 LeaderRace = leader->getRace();
+ if (player->getFaction() != leader->getFaction())
+ {
+ uint8 LeaderRace = leader->getRace();
- player->setRace(LeaderRace);
- player->setTeamId(leader->TeamIdForRace(LeaderRace));
+ player->OldFactionID = player->getFaction();
+ player->setRace(LeaderRace);
+ player->setTeamId(leader->TeamIdForRace(LeaderRace));
- ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
- player->setFaction(CharRace ? CharRace->FactionID : 0);
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
+ }
}
for (GroupReference* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next())
diff --git a/src/server/game/DungeonFinding/LFGScripts.cpp b/src/server/game/DungeonFinding/LFGScripts.cpp
index 4d715101f1..32d2207996 100644
--- a/src/server/game/DungeonFinding/LFGScripts.cpp
+++ b/src/server/game/DungeonFinding/LFGScripts.cpp
@@ -76,13 +76,16 @@ void LFGPlayerScript::OnLogin(Player* player)
{
if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
{
- uint8 LeaderRace = leader->getRace();
+ if (player->getFaction() != leader->getFaction())
+ {
+ uint8 LeaderRace = leader->getRace();
- player->setRace(LeaderRace);
- player->setTeamId(leader->TeamIdForRace(LeaderRace));
+ player->setRace(LeaderRace);
+ player->setTeamId(leader->TeamIdForRace(LeaderRace));
- ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
- player->setFaction(CharRace ? CharRace->FactionID : 0);
+ ChrRacesEntry const* CharRace = sChrRacesStore.LookupEntry(LeaderRace);
+ player->setFaction(CharRace ? CharRace->FactionID : 0);
+ }
}
Group* group2 = player->GetGroup();
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index c3b9998088..beaf42ac37 100644
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -676,6 +676,8 @@ Player::Player(WorldSession* session): Unit(true), m_mover(this)
#pragma warning(default:4355)
#endif
+ OldFactionID = 0;
+
m_drwGUID = 0;
m_speakTime = 0;
m_speakCount = 0;
diff --git a/src/server/game/Entities/Player/Player.h b/src/server/game/Entities/Player/Player.h
index 09fb52a6ed..3188347681 100644
--- a/src/server/game/Entities/Player/Player.h
+++ b/src/server/game/Entities/Player/Player.h
@@ -2615,6 +2615,7 @@ class Player : public Unit, public GridObject<Player>
uint32 GetNextSave() const { return m_nextSave; }
SpellModList const& GetSpellModList(uint32 type) const { return m_spellMods[type]; }
+ uint32 OldFactionID;
protected:
// Gamemaster whisper whitelist
WhisperListContainer WhisperList;
diff --git a/src/server/game/DungeonFinding/LFGMgr.cpp b/src/server/game/DungeonFinding/LFGMgr.cpp
index d9c0b86814..3c68bae9d0 100644
--- a/src/server/game/DungeonFinding/LFGMgr.cpp
+++ b/src/server/game/DungeonFinding/LFGMgr.cpp
@@ -2001,6 +2001,8 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
if (player->TeleportTo(mapid, x, y, z, orientation))
{
+ player->OldFactionID = player->getFaction();
+
if (group && sWorld->getBoolConfig(CONFIG_ALLOW_CROSSFACTION_DUNGEON))
{
if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
@@ -2009,7 +2011,6 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
{
uint8 LeaderRace = leader->getRace();
- player->OldFactionID = player->getFaction();
player->setRace(LeaderRace);
player->setTeamId(leader->TeamIdForRace(LeaderRace));
diff --git a/src/server/game/DungeonFinding/LFGMgr.cpp b/src/server/game/DungeonFinding/LFGMgr.cpp
index 3c68bae9d0..7fc218ee45 100644
--- a/src/server/game/DungeonFinding/LFGMgr.cpp
+++ b/src/server/game/DungeonFinding/LFGMgr.cpp
@@ -2001,8 +2001,6 @@ void LFGMgr::TeleportPlayer(Player* player, bool out, bool fromOpcode /*= false*
if (player->TeleportTo(mapid, x, y, z, orientation))
{
- player->OldFactionID = player->getFaction();
-
if (group && sWorld->getBoolConfig(CONFIG_ALLOW_CROSSFACTION_DUNGEON))
{
if (Player* leader = ObjectAccessor::FindPlayerInOrOutOfWorld(group->GetLeaderGUID()))
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index beaf42ac37..e5cda0ddac 100644
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -1218,6 +1218,7 @@ bool Player::Create(uint32 guidlow, CharacterCreateInfo* createInfo)
CheckAllAchievementCriteria();
+ OldFactionID = getFaction();
return true;
}
@@ -18409,6 +18410,8 @@ bool Player::LoadFromDB(uint32 guid, SQLQueryHolder *holder)
if (!HasAuraState((AuraStateType)m_spellInfo->CasterAuraState))
aura->HandleAllEffects(itr->second, AURA_EFFECT_HANDLE_REAL, false);
}
+
+ OldFactionID = getFaction();
return true;
}