Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make long local profile names readable on the page listing profiles - Le Même en Nord-Pas-de-Calais etc. #1144

Closed
MaartenLMEM opened this issue Sep 24, 2021 · 7 comments · Fixed by #1145
Closed

Make long local profile names readable on the page listing profiles - Le Même en Nord-Pas-de-Calais etc. #1144

MaartenLMEM opened this issue Sep 24, 2021 · 7 comments · Fixed by #1145
Assignees
@MaartenLMEM
Labels
Le Même en Local extensions Le Même en Local released

Comments

@MaartenLMEM
Copy link
Contributor

See https://proding-profiles.dismoi.io/eclaireurs profiles beginning with Le même en ...
Challenge here is that if we resize one part we ll have to rezise others.
@newick
Copy link
Member

newick commented Sep 27, 2021

After discussion with @zhinu it has been chosen to display profiles on 2 columns.
Profile's name could be around 50 characters

@newick
Copy link
Member

newick commented Sep 27, 2021

btw it's an extension issue ;)

@MaartenLMEM MaartenLMEM transferred this issue from dis-moi/websites Sep 27, 2021
@newick newick mentioned this issue Sep 27, 2021
Merged
@JalilArfaoui JalilArfaoui added the Le Même en Local extensions Le Même en Local label Oct 21, 2021
@bmenant
Copy link
Member

bmenant commented Oct 31, 2021

🎉 This issue has been resolved in version 3.88.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@MaartenLMEM
Copy link
Contributor Author

I cannot veirfy this feature since I cannot reach the proding profile page anymore : https://github.com/dis-moi/backend/issues/464

@MaartenLMEM MaartenLMEM assigned JalilArfaoui and unassigned newick and zhinu Nov 2, 2021
@JalilArfaoui
Copy link
Member

@MaartenLMEM #1167 is now fixed.

@prk-dismoi
Copy link

I cannot access the page https://proding-profiles.dismoi.io/eclaireurs therefore cannot check this one again.

@JalilArfaoui
Copy link
Member

Indeed @prk-dismoi 😭 … I’m working on it, I created an official issue : #1188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaartenLMEM MaartenLMEM

Labels
Le Même en Local extensions Le Même en Local released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(profilesList): changes list item width dis-moi/extension
6 participants
@newick @bmenant @JalilArfaoui @MaartenLMEM @zhinu @prk-dismoi