Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution from extension : matching only the page targeted, not all pages starting by #461

Open
MaartenLMEM opened this issue Oct 6, 2021 · 0 comments

Comments

@MaartenLMEM
Copy link
Contributor

Problem
Currently, when an web extension user contributes it creates a mathing context too large. It target the page and all pages starting with same characters.
Currently it is not a problem because contribution team is moderating contributions before publishing.
Tomorrow with #459, it will be directly published.

For example
if I am on https://www.direct-assurance.fr/ when I contribute
it creates as matching context :

  • websiste : www.direct-assurance.fr
  • regex : /

Solution
Add /?(\?.*)?$ at the end of regex to not match with other pages of the same website
Fo example
if I am on https://www.direct-assurance.fr/ when I contribute
it creates as matching context :

  • websiste : www.direct-assurance.fr
  • regex : /?(\?.*)?$
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant