-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On mobile, some domains starting with "m dot" are not covered by bubbles whereas they should appear #429
Comments
Discussed with @JalilArfaoui yesterday :
Please Jalil add also a comments field for contributors. It will be usefull for us to explain choices we made for protodomains and alias. |
Pour rappel, 2 risques si on ne specifie pas le www. ou le M. aujourd'hui :
|
Pour Résoudre le risques 1 :
Pour les sites : ça évite : Pour le risque 2 : Si on souhaite viser un protodomaine précis, on pourrait penser à une regex telle que :
Ça viserait les sites |
Looks enough for me, but I'm probably missing something...
Isn't it exactly what we're trying to achieve here? ex: match |
What do you think @JalilArfaoui ? |
These are questions here about the need. @zhinu don't hesistate to answer or complete.
Yes and no.
|
Maybe the matter here is just |
Yes, to me, the issue here is simply : Add an
(instead of currently Do we all agree of that ? |
Yes, we agree on this solution @JalilArfaoui Current situation
Targeted functioningNew feature : ALIAS field that can contain multiple values in domains part Operations
(thus like currently)
but not :
|
Aliases are mapped to a simple php array, there is a little hack to overcome an issue with Doctrine's `simple_array` which maps the `[]` to `null` in database, hence the oddities you can see in the `DomainName` entity. This also update the "big" regexp we expose with the possible aliases of domain. (see updated tests for example of generated regexp). The same validation rule as a `Domain` `name` has been added to each `aliases` element but both seems to be ignored by __ZiziAdmin__... > This fix issue #429 💋
Aliases are mapped to a simple php array, there is a little hack to overcome an issue with Doctrine's `simple_array` which maps the `[]` to `null` in database, hence the oddities you can see in the `DomainName` entity. This also update the "big" regexp we expose with the possible aliases of domain. (see updated tests for example of generated regexp). The same validation rule as a `Domain` `name` has been added to each `aliases` element but both seems to be ignored by __ZiziAdmin__... > This fix issue #429 💋
Problème
Les sites web couverts ont parfois des versions mobile débutant par M point , et non www.
Par suite, les bulles n'apparaissent pas sur mobile, notamment dans les exemples phares.
Parmi les sites déjà identifiés dans ce cas :
et bien d'autres
The text was updated successfully, but these errors were encountered: