You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Amongst other things, I expect this limitation means that https://github.com/reviewdog/reviewdog (and similar, diff-based approaches) won't fail PRs that introduce linting errors, meaning we lost a critical enforcement of these policies.
as I remember graphql-tag-pluck returns compiled code for vue/svelte files, as result - location of extracted documents will be incorrect from the source file
Maybe there is some workaround to parse vue/svelte files with vue/svelte parsers and run graphql-eslint processor on extracted js/ts code-blocks, example
Oh interesting, yeah that limitation makes sense. Thanks for the detail, I appreciate it. I suspect the strings are often the same, so also a naive string match could work to correct the locations?
I don't quite understand how the workaround with parsers would maintain location information. Why wouldn't that have the same limitation?
Just to jot down an idea I had here: pluck could add a magic comment at the top of its output, which includes the location it was extracted from. Then this could be read and added as an offset when reporting the lint.
Is it possible to resolve the limitations that results in the workaround introduced at #1346 ?
The text was updated successfully, but these errors were encountered: