Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: line length in .flake8 #322

Open
sbillinge opened this issue Jan 17, 2025 · 0 comments
Open

fix: line length in .flake8 #322

sbillinge opened this issue Jan 17, 2025 · 0 comments

Comments

@sbillinge
Copy link
Contributor

Problem

We are using diffpy.utils as the example package in scikit-package but the .flake8 file still hsa our old standard of 115 character line length in it and not the new standard of 79. So running flake8 vs running pre-commit ressults in different outcomes (pre-commit seems to use the flake8 hook in .pre-commit-config to override whatever is in .flake8).

Proposed solution

change line-length in .flake8 to 79 and push out at least a minor release bump before scikit-package goes public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant