Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _clear() in DataClusters class #63

Open
stevenhua0320 opened this issue Aug 13, 2024 · 3 comments
Open

Remove _clear() in DataClusters class #63

stevenhua0320 opened this issue Aug 13, 2024 · 3 comments

Comments

@stevenhua0320
Copy link
Contributor

No description provided.

@sbillinge
Copy link
Contributor

It should not be needed but make sure the behavior doesn't change when we do that

@Ainamacar
Copy link
Contributor

This should be OK if incorporating its functionality into init, that is the only call to _clear().

I had originally made this a public member so classes in other modules that had a DataClusters member could use it when they cleared their members. However, in the existing implementation all instances of DataClusters are local variables that are created when needed and drop out of scope when not, so that functionality never came up.

@sbillinge
Copy link
Contributor

Thanks @Ainamacar . We normally try and keep the the code simple so let's leave this as an open issue. It is not high priority. Just general code hygiene that we note down when we find it and clean up from time to time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants