Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor comparing length of dictionary mapping string keys (e.g. "position") #141

Open
bobleesj opened this issue Oct 24, 2024 · 0 comments
Open

Refactor comparing length of dictionary mapping string keys (e.g. "position") #141

bobleesj opened this issue Oct 24, 2024 · 0 comments

Comments

@bobleesj
Copy link
Contributor

The changes in the PR were implemented to ensure compatibility with Python 3.12. However, the code was deemed brittle, so refactoring should be considered.

Originally posted by @sbillinge in #137 (comment)
@bobleesj bobleesj changed the title Refactor dictionary mapping string keys (e.g. "position") to their index in a sequence of parameters of PeakFunction subclass. Refactor comparing length of dictionary mapping string keys (e.g. "position") Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobleesj