Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flowchart for stretched_nmf algorithm #26

Open
aajayi-21 opened this issue Jul 25, 2023 · 8 comments
Open

flowchart for stretched_nmf algorithm #26

aajayi-21 opened this issue Jul 25, 2023 · 8 comments

Comments

@aajayi-21
Copy link
Contributor

SNMF Design

@sbillinge
Copy link
Contributor

This is a great start. Let's make an even higher level one that has all the internals as an empty box and it describes the inputs and the outputs. For the inputs, separate user-supplied inputs and the input files. For the outputs describe what form they are (such and such files, json dump etc) as well as what they are. This figure will be super-useful because it shows where we are starting from and where we are trying to get to, so we can try and figure out how we want to propagate arrays and data objects internally in such a way that we can get there.

Next, on the current figure, it would be helpful to have a bit more detail on what things are. For example, I see "calculate the value of the objective function, but what that function is is not defined. Is it sum of squares of agreement between calculated and measure curves across the entire set of input curves? Or just one? And so on.

@sbillinge
Copy link
Contributor

really great though.....really helpful!

@aajayi-21
Copy link
Contributor Author

Ok. I will do these things.

@aajayi-21
Copy link
Contributor Author

In your first paragraph, I don't think I am 100% sure what you mean by making the design even higher level.

@aajayi-21
Copy link
Contributor Author

SNMF Flowchart 2

@sbillinge
Copy link
Contributor

sbillinge commented Jul 26, 2023

In your first paragraph, I don't think I am 100% sure what you mean by making the design even higher level.

I mean the program is just an empty box (like a black box) and you are just showing what the inputs to the black box are and the outputs, but those in puts and outputs are quite detailed including types etc., file formats, etc.

What you supplied is not what I wanted because you did the inputs and the outputs of each sub-unit. I am trying to get a very high-level picture of the objective.

From what you wrote I think the inputs are
User input: string with path to a folder where the cif files are
Data inputs: files on disk that are text files in cif format

outputs:
I am still not sure from your flow-chart what the app will output.

@aajayi-21
Copy link
Contributor Author

Blank diagram

@sbillinge
Copy link
Contributor

sbillinge commented Jul 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants