Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Model Downloader Flow #31

Open
1 task done
iwr-redmond opened this issue Dec 5, 2024 · 6 comments
Open
1 task done

[Feature Request]: Model Downloader Flow #31

iwr-redmond opened this issue Dec 5, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@iwr-redmond
Copy link

iwr-redmond commented Dec 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

Summary

At the moment Flow appears to require some manual model downloading and/or work within ComfyUI Manager. This model setup process could be automated with the comfyui-model-downloader extension to create a one-click "Get Started" flow.

Such a feature would allow for easier onboarding with new users who have limited or no data archive, while also providing an in-app model update mechanism for end users.

Description

  1. Make a list of all the dependent files required.
  2. Use the ControlFlowUtils Folder Search node to detect each existing Checkpoints/Loras/etc.
  3. Use the aforementioned Model Downloader to obtain each missing data file.

Additional information

Note 1: If all the files are hosted on Huggingface, this proposed Flow could be radically simplified to eliminate ControlFlowUtils. The CivitiAI downloader blindly overwrites existing files, while the HuggingFace downloader can be told to skip existing files.

Note 2: Performing this task within ComfyUI will make future compatibility with the Desktop Electron app more feasible.

@iwr-redmond iwr-redmond added the enhancement New feature or request label Dec 5, 2024
@iwr-redmond
Copy link
Author

Looking at missingPackagesDialog.js, this might become a bug report. On both Windows and Linux, I don't recall encountering the features therein.

@diStyApps
Copy link
Owner

Thank you i will look into it, I read somewhere that ComfyUI should have their own model downloader directly on the nods like the nodes you presented.

If not i plan to add a downloader to the up coming future updates models gallery.

If you mean you have not seen this missing nodes dialog, maybe you have all the require nods to run the premade "Flows" are installed.

@iwr-redmond
Copy link
Author

If you mean you have not seen this missing nodes dialog, maybe you have all the require nods to run the premade "Flows" are installed.

Possibly. All I preloaded in the test installs were Impact Pack and Inspire Pack, as well as two UI extensions (Model Manager and Image Browsing).

@iwr-redmond
Copy link
Author

Retried today, and the node installer works perfectly. This feature request for a model downloader workflow appears correctly conceived.

@iwr-redmond
Copy link
Author

I've done a quick opinionated audit of current workflows and made a start on a file download list: datafiles_draft.csv

Notes

  1. SD35 Large replaced with the FP8 version - workflow needs to be updated
  2. SD35 T5XXL FP16 replaced with FP8 version - workflow needs to be updated
  3. AntiBlur Lora has a different filename on HF - workflow needs to be updated
  4. EnvyFlux80sBookCovers01.safetensors is only available on Civitai - recommend uploading to HF
  5. Categories do not reflect ComfyUI's model folders

@nyukers
Copy link

nyukers commented Jan 15, 2025

Please make the workflows for FLUX-es so that they are distributed to the entire folder with models by extra_model_paths.yaml, not just to the diffusion_models folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants