Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ka-Block breaks navigation in AWS documentation #193

Open
lrworth opened this issue Feb 2, 2023 · 2 comments · May be fixed by #194
Open

Ka-Block breaks navigation in AWS documentation #193

lrworth opened this issue Feb 2, 2023 · 2 comments · May be fixed by #194

Comments

@lrworth
Copy link

lrworth commented Feb 2, 2023

Clicking links in the left-hand pane of any AWS documentation (e.g. https://docs.aws.amazon.com/AmazonS3/latest/API/Welcome.html) causes the following console error (from Ka-Block):

Content blocker prevented frame displaying https://docs.aws.amazon.com/AmazonS3/latest/API/API_CompleteMultipartUpload.html from loading a resource from https://a0.awsstatic.com/s_code/js/3.0/awshome_s_code.js

This completely breaks the navigation system within all AWS documentation — the browser back button does not work and links within the page do not work.
@dgraham
Copy link
Owner

dgraham commented Feb 6, 2023

The dot is unescaped and is matching any character. In this case, it's the / in /s_code/js.

Ka-Block/Shared (Extension)/blockerList.json

Line 34 in f2bfbf1

"url-filter": "/s_code.js",

@lrworth lrworth linked a pull request Feb 6, 2023 that will close this issue
Open
@lrworth
Copy link
Author

lrworth commented Feb 6, 2023

Thanks for pointing that out @dgraham

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make /s_code.js filter more precise lrworth/Ka-Block
2 participants
@dgraham @lrworth