refactor(sns): Separate UpgradeInProgress and PendingVersion #2469
+102
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterga
reviewed
Nov 6, 2024
aterga
reviewed
Nov 6, 2024
anchpop
changed the title
anchpop
force-pushed
the
@anchpop/upgrade-in-progress-api-split
branch
from
b332887
to
a35ab51
Compare
aterga
approved these changes
Nov 6, 2024
anchpop
force-pushed
the
@anchpop/upgrade-in-progress-api-split
branch
2 times, most recently
from
60fd564
to
aafbc98
Compare
anchpop
added
the
CI_OVERRIDE_BUF_BREAKING
anchpop
force-pushed
the
@anchpop/upgrade-in-progress-api-split
branch
from
aafbc98
to
de7baf2
Compare
anchpop
force-pushed
the
@anchpop/upgrade-in-progress-api-split
branch
from
de7baf2
to
5e8fbb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this PR, UpgradeInProgress is used in the API, while PendingVersion is used internally. This will allow us to evolve them separately.
This is not actually a breaking change as far as proto is concerned