Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a JS user, I want to be able to pass Array<Number>, Blob, or ArrayBuffer for blobs #308

Open
krpeacock opened this issue Jan 5, 2022 · 0 comments
Open

As a JS user, I want to be able to pass Array<Number>, Blob, or ArrayBuffer for blobs #308

krpeacock opened this issue Jan 5, 2022 · 0 comments
Assignees
@chenyan-dfinity
Labels
enhancement New feature or request JavaScript

Comments

@krpeacock
Copy link
Contributor

We currently type the blob type as specifically an Array of numbers, which feels silly in contexts where we are working with Blobs and ArrayBuffers.

Instead, the types allowed should include Blob and ArrayBuffer, and we should add support in the JS Agent for accepting those compatible values and encoding them appropriately.

Acceptance criteria:

  • Blobs can accept Array<Number> | Blob | ArrayBuffer in TS Codegen
@krpeacock krpeacock added enhancement New feature or request JavaScript labels Jan 5, 2022
ninegua pushed a commit to ninegua/candid that referenced this issue Apr 22, 2022
fix: button design on mobile (dfinity#308)
dcd553d 
* Fix continue button style on small screens

* Added newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenyan-dfinity chenyan-dfinity

Labels
enhancement New feature or request JavaScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krpeacock @chenyan-dfinity