Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rewards_by_day.time field to a timestamp column #22

Open
jamiew opened this issue Oct 12, 2021 · 2 comments
Open

Convert rewards_by_day.time field to a timestamp column #22

jamiew opened this issue Oct 12, 2021 · 2 comments
Assignees

Comments

@jamiew
Copy link
Contributor

jamiew commented Oct 12, 2021

Currently a bigint storing a unixtime

Using timestamp (or time with zone) would allow us to use Metabase's date-filtering logic out-of-the-box

cc @dansku

@jamiew
Copy link
Contributor Author

jamiew commented Oct 12, 2021

BTW I wonder if we would also want to restrict visibility for the rewards table? Nobody really needs <day granularity, and people querying rewards directly will only find a dead-end. I wouln't be surprised if it started causing performance hiccups by pushing better things out of memory etc

@dansku
Copy link
Collaborator

dansku commented Oct 13, 2021

I am working on it!
About the rewards restriction, would it be via metabase?

@dansku dansku self-assigned this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants