Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ping and issues triggers check for more specific messages #10

Open
sethetter opened this issue Oct 12, 2023 · 4 comments · May be fixed by #15
Open

Make ping and issues triggers check for more specific messages #10

sethetter opened this issue Oct 12, 2023 · 4 comments · May be fixed by #15
Assignees
@melicent
Labels
devict-help-wanted good first issue Good for newcomers

Comments

@sethetter
Copy link
Member

Right now the ping and issues triggers will fire if the bot is mentioned in the message, and anywhere in the message text contains the strings ping or issues, which can result in a lot of false positives.

Update the filters for those triggers to check that the message equals exactly <@BOT-ID> ping (or issues) instead of using just CONTAINS.

Here are the Slack docs on trigger filters.
@melicent
Copy link

I'm interested in working on this (please let me, I'm a typescript noob)

@sethetter
Copy link
Member Author

@melicent it's yours! :)

@JayGaba
Copy link

JayGaba commented Oct 13, 2024

@sethetter I would like to work!

@JayGaba JayGaba linked a pull request Oct 13, 2024 that will close this issue
Open
@JayGaba
Copy link

JayGaba commented Oct 13, 2024

@sethetter could you review the changes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melicent melicent

Labels
devict-help-wanted good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented a REGEX check for <@ID> JayGaba/keeper
3 participants
@sethetter @melicent @JayGaba