Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update website with new icons #4

Open
Snailedlt opened this issue Feb 6, 2024 · 3 comments
Open

Update website with new icons #4

Snailedlt opened this issue Feb 6, 2024 · 3 comments

Comments

@Snailedlt
Copy link

No description provided.

@Snailedlt
Copy link
Author

We just did a new release for devicons, but the new icons aren't showing up on this website.

@risbi0 do you have any ideas why that is?

@canaleal
Copy link
Member

canaleal commented Feb 8, 2024

Hey @Snailedlt, the website has a data.ts file with all the icons found here.

When it's time to create the angular page component, the icons are loaded here, and then parsed.

A simple fix would be to create a new file to fetch the devicon.json file from devicon instead of using the local file.

@Snailedlt
Copy link
Author

Thanks for the insight @canaleal!
yeah, fetching from devicons/devicon seems like a better option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants