Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avram schema validation #288

Closed
2 tasks
nwagner84 opened this issue Sep 20, 2021 · 3 comments
Closed
2 tasks

Avram schema validation #288

nwagner84 opened this issue Sep 20, 2021 · 3 comments
Assignees
Labels
backlog Backlog items C-enhancement Category: enhancement

Comments

@nwagner84
Copy link
Member

Specification: https://format.gbv.de/schema/avram/specification

  • Add Avram schema parser
  • Add --schema parameter
@nwagner84 nwagner84 added the C-enhancement Category: enhancement label Sep 20, 2021
@nwagner84 nwagner84 added this to the v0.7.0 milestone Sep 20, 2021
@nwagner84 nwagner84 self-assigned this Sep 20, 2021
@nichtich
Copy link
Contributor

See this issue for a list of error types. I did not find JUnit XML a good fit to express error results.

@nwagner84
Copy link
Member Author

My current plan is to extend the current validation (valid PICA+ record or not) by the validation against an Avram schema. This means to add a new parameter to almost all commands to take an Avram schema into account and skip invalid records (if the parameter is set) or stop the processing (if the flag is not set).

The second step is the lint command (see #117) with an Avram linter (among other linters). At this point the error output format is important (and JUnit was a first idea). I'll definitely look at the linked issue when choosing a good output format.

@nwagner84 nwagner84 removed this from the v0.7.0 milestone Nov 17, 2021
@nwagner84 nwagner84 added the backlog Backlog items label Nov 17, 2021
@nwagner84
Copy link
Member Author

nwagner84 commented Jan 30, 2023

In the meantime, a small team at the DNB created the experimental pica-linter tool, which focus on pica filter expression for validaten (besides other lints). This works very well and the tool will enter the beta-phase until the end of year.

I close this ticket, because Avram schema validation is no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Backlog items C-enhancement Category: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants