Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use API to query ampel #1

Closed
robertdstein opened this issue May 12, 2021 · 4 comments
Closed

Use API to query ampel #1

robertdstein opened this issue May 12, 2021 · 4 comments
Assignees
@simeonreusch @SWeimann93
Labels
bug Something isn't working enhancement New feature or request

Comments

@robertdstein
Copy link
Member

Is your feature request related to a problem? Please describe.
I'm always frustrated when the Ampel database access changes like every 30 seconds.

Describe the solution you'd like
Swap from using ampel-ztf-archive to the ampel API.
All references to ampel_client in ampel_magic.py must be purged.

Describe alternatives you've considered
Leaving things as they are. It'll require many urgent updates/hot-fixes, but will add a certain sense of adventure to our otherwise mundane lives.
@robertdstein robertdstein added the enhancement New feature or request label May 12, 2021
@robertdstein robertdstein mentioned this issue May 12, 2021
Closed
simeonreusch added a commit that referenced this issue May 14, 2021
@simeonreusch
progress on #1, replaced password handling with ztfquery-based code
fc64584
simeonreusch added a commit that referenced this issue May 19, 2021
@simeonreusch
further deprecation of direct DB access, progress on #1
d4b18ff
simeonreusch added a commit that referenced this issue May 19, 2021
@simeonreusch
deprecated ArchiveDB, progress on #1
0924dbb
simeonreusch added a commit that referenced this issue May 19, 2021
@simeonreusch
performance improvements, bugfix, progress on #1
09b13fd
simeonreusch added a commit that referenced this issue May 20, 2021
@simeonreusch
bugfix, removed unnecessary rate limit, progress on #1
9ebb4d2
simeonreusch added a commit that referenced this issue May 21, 2021
@simeonreusch
migrated TNS query to API, progress on #1
8c4796f
simeonreusch added a commit that referenced this issue May 21, 2021
@simeonreusch
replaced all other catalog queries with API, progress on #1
92266d7
simeonreusch added a commit that referenced this issue May 21, 2021
@simeonreusch
deprecation done, progress on #1
2fb8883
@robertdstein
Copy link
Member Author

I think this issue is not fully complete, because https://github.com/desy-multimessenger/ampel_followup_pipeline/blob/master/mmapy/gw_multi_process.py has not been ported yet.

@robertdstein robertdstein reopened this Jun 3, 2021
@JannisNe
Copy link
Collaborator

JannisNe commented Jun 3, 2021

There is also some usage of ArchiveDB in TNS_submit.py. Related to #7

@JannisNe JannisNe added the bug Something isn't working label Sep 27, 2021
@JannisNe
Copy link
Collaborator

Note: This is still open because the GW and GRB part of the code still needs to be ported.

@simeonreusch
Copy link
Collaborator

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonreusch simeonreusch

@SWeimann93 SWeimann93

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robertdstein @JannisNe @simeonreusch @SWeimann93